Address Selenium warnings #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
changed the title
michplunkett
commented
Nov 22, 2024
Comment on lines
+17
to
+18
| ENV GECKODRIVER_VERSION="v0.35.0" | ||
| ENV GECKODRIVER_SHA=ac26e9ba8f3b8ce0fbf7339b9c9020192f6dcfcbf04a2bcd2af80dfe6bb24260 |
There was a problem hiding this comment.
Driver: link
michaelp@MacBook-Air-18 Downloads % shasum -a 256 geckodriver-v0.35.0-linux64.tar.gz
ac26e9ba8f3b8ce0fbf7339b9c9020192f6dcfcbf04a2bcd2af80dfe6bb24260 geckodriver-v0.35.0-linux64.tar.gz
michaelp@MacBook-Air-18 Downloads %
michplunkett
commented
Nov 22, 2024
| @@ -56,13 +56,12 @@ recommonmark==0.7.1 | |||
| requests~=2.31.0 | |||
| rich~=13.4.2 | |||
| s3transfer~=0.6.1 | |||
| selenium~=4.10.0 | |||
There was a problem hiding this comment.
This is only used in tests, so I moved it to dev-requirements.txt.
michplunkett
commented
Nov 22, 2024
| result = browser.find_element_by_id("description-overflow-row_1") | ||
| result = browser.find_element(By.ID, "description-overflow-row_1") |
There was a problem hiding this comment.
Making find_element syntax consistent.
michplunkett
changed the title
michplunkett
requested review from
b-meson,
AetherUnbound,
abandoned-prototype and
sea-kelp
b-meson
approved these changes
Nov 22, 2024
|
That's a different warning. That can be addressed in another PR, imo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Screenshots (if appropriate)
Before change:
After change (selenium warnings are gone:
Tests and Linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.